This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Version update #2311
Merged
Version update #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added support for different version identifier locations
|
Good idea 👍 |
|
How about accepting as additional optional parameter, that excepts a |
|
@coss That's outside the scope of this PR; if you'd like to have that feature, please open a new request. :) |
|
Merged to release and master branches. |
ghost
assigned 
| const VERSION_SERVICE_GITHUB = 'GITHUB'; | ||
|
|
||
| /** | ||
| * Github Service Identifier for version information is retreived from |
There was a problem hiding this comment.
Since this has already been merged and done, I've created #2404
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Zend\Version\Version to enable support for classic version retrieval from framework.zend.com